-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated jupyterhub_config.py has whitelist error #885
Comments
How did you run the config generation? This is what I get: #c.Authenticator.whitelist = set() which is correct. |
Hi @hokiegeek2, Thanks for the issue report. I'm getting the same results as @minrk for Python 3.5 (as a reminder JupyterHub runs on Python3). Out of curiousity, how did you install JupyterHub? Perhaps there was already a config file in your environment. I'm going to go ahead and close this issue since we can't replicate it. If you have additional information, I would be happy to look into it. Thanks! - Carol |
Hey Everyone, I apologize for the delay in following up on this. @minrk Yes, the config generation results in this format. However, when I manually set the users in this data structure: When I switch to this, the whitelist filter works correctly: --John |
Thanks for the update @hokiegeek2. @minrk Do we want to edit the comment about whitelist and/or add a note in the docs? |
I've opened #885 to give a more informative message when it sees that a whitelist contains single-character usernames. |
Thanks @minrk 🍪 |
Hi Everyone,
Minor issue with jupyterhub_config.py that is generated by jupyterhub command. The string is as follows:
#c.Authenticator.whitelist = set('')
This causes all user logins to fail. When I changed it to the following--which is on the Getting Started page--the whitelist worked as expected:
c.Authenticator.whitelist = {''}
Again, minor issue, but it may trip up Python newbies. :)
--John
The text was updated successfully, but these errors were encountered: