-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change not found output when getting non namespaced resources #89861
Change not found output when getting non namespaced resources #89861
Conversation
Hi @rccrdpccl. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
1 similar comment
/retest |
Signed-off-by: Riccardo Piccoli <riccardo.piccoli@gmail.com>
a34f642
to
818f011
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/retest
/priority backlog
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rccrdpccl, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Riccardo Piccoli riccardo.piccoli@gmail.com
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Removes namespace mentions on not found message for when running get on namespaced resources.
Before this PR:
$ kubectl get pv No resources found in default namespace.
After this PR:
Which issue(s) this PR fixes:
Fixes kubernetes/kubectl#757
Does this PR introduce a user-facing change?: