Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysqlcluster: Support automatic rebuild of nodes by label. #389

Merged
merged 1 commit into from
Mar 17, 2022
Merged

mysqlcluster: Support automatic rebuild of nodes by label. #389

merged 1 commit into from
Mar 17, 2022

Conversation

acekingke
Copy link
Contributor

What type of PR is this?

/enhancement

Which issue(s) this PR fixes?

Fixes #385

What this PR does?

Summary:

  1. track lable rebuild and rebuild the pod

Special notes for your reviewer?

@acekingke acekingke added the enhancement New feature or request label Feb 24, 2022
@acekingke acekingke added this to the Next milestone Feb 24, 2022
@acekingke acekingke self-assigned this Feb 24, 2022
@acekingke acekingke marked this pull request as draft February 24, 2022 08:39
runkecheng
runkecheng requested changes Feb 28, 2022
View reviewed changes
mysqlcluster/syncer/status.go Outdated Show resolved Hide resolved
mysqlcluster/syncer/status.go Show resolved Hide resolved
@acekingke acekingke requested a review from runkecheng March 7, 2022 02:19
@acekingke acekingke marked this pull request as ready for review March 7, 2022 02:19
andyli029
andyli029 approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@andyli029 andyli029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Add command
  2. Fix the commit log

@runkecheng runkecheng changed the title mysqlcluster: Support the more elegant way to rebuild node. #385 mysqlcluster: Support automatic rebuild of nodes by label. Mar 14, 2022
@acekingke acekingke force-pushed the LableRebuild branch 2 times, most recently from ba2077a to a217208 Compare March 17, 2022 03:27
andyli029
andyli029 reviewed Mar 17, 2022
View reviewed changes
Copy link
Contributor

@andyli029 andyli029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@andyli029 andyli029 merged commit 0e723fd into radondb:main Mar 17, 2022
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
@andyli029
Merge pull request radondb#389 from acekingke/LableRebuild
69f301a 
mysqlcluster: Support automatic rebuild of nodes by label.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyli029 andyli029 andyli029 approved these changes

@runkecheng runkecheng runkecheng approved these changes

Assignees

@acekingke acekingke

Labels
enhancement New feature or request
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.

[feature] Support the more elegant way to rebuild node.
3 participants
@acekingke @andyli029 @runkecheng